fix(hdfs): EC-safe reads for Parquet/ORC and libhdfs3 striped reader#522
Open
zhanglistar wants to merge 2 commits into
Open
fix(hdfs): EC-safe reads for Parquet/ORC and libhdfs3 striped reader#522zhanglistar wants to merge 2 commits into
zhanglistar wants to merge 2 commits into
Conversation
- Add PositionStripeReader.cpp to libhdfs3-cmake SRCS (fix undefined PositionStripeReader symbol when linking StripedInputStreamImpl). - HDFS ReadBufferBuilder: do not trust Substrait properties.filesize for Parquet/ORC (incl. Iceberg); always stat real length for footer/postscript. - Parquet: prefer RandomAccessFileFromRandomAccessReadBuffer when readBigAt is available so footer ReadAt uses pread, not seek+read. - ORC (Gluten): OrcUtil path mirrors the same Arrow RandomAccessFile choice where applicable. - NativeORCBlockInputFormat: decouple offset-based read (readBigAt) from use_prefetch so Gluten (use_prefetch=false) still uses pread on HDFS EC; rename flag to use_offset_based_read for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes